session: set tidb_opt_range_max_size to 0 when upgrading to v6.4.0+ #38694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
14 tasks
ti-chi-bot
removed
the
needs-rebase
xuyifangreeneyes
force-pushed
the
range-limit-upgrade
branch
from
0266247
to
978f4dc
Compare
winoros
approved these changes
Oct 28, 2022
XuHuaiyu
approved these changes
Oct 28, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 99694ad
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #37176
Problem Summary:
What is changed and how it works?
v6.4.0 introduces
tidb_opt_range_max_sizeto do memory control for building ranges. Its default value is 64MB. However, when a cluster upgrades from some version lower than v6.4.0 to v6.4.0+, we need to settidb_opt_range_max_sizeto0for compatibility. In this way there is no memory control for building ranges, which is the old behavior before we introduce this variable.Check List
Tests
Use v6.2.0 cluster, patch the pr's TiDB,
select @@tidb_opt_range_max_sizereturns0.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.